Actually move out of Box in moving-out-of-Box test#2204
Merged
ehuss merged 1 commit intorust-lang:masterfrom Mar 13, 2026
Merged
Actually move out of Box in moving-out-of-Box test#2204ehuss merged 1 commit intorust-lang:masterfrom
ehuss merged 1 commit intorust-lang:masterfrom
Conversation
rustbot
added
the
S-waiting-on-review
dianne
commented
Mar 11, 2026
src/expressions/operator-expr.md
Outdated
| assert_eq!(*y, 11); | ||
| let z = Box::new(NoCopy); | ||
| let _: NoCopy = *z; | ||
| let _z: NoCopy = *z; |
Contributor
Author
There was a problem hiding this comment.
drop::<NoCopy>(*z) or { *z } would also get the job done here. Maybe the drop would be the most explicit? Using a pattern binding is a bit more subtle; I expect it may not be obvious if you're not deeply in the weeds already that _z differs from _.
ehuss
reviewed
Mar 11, 2026
src/expressions/operator-expr.md
Outdated
Comment on lines
+188
to
+189
| let z = Box::new(NoCopy); | ||
| let _: NoCopy = *z; | ||
| let _z: NoCopy = *z; |
Contributor
There was a problem hiding this comment.
I think to maintain consistency with the rest of the example above, it's fine to just assign to a local.
Since we have kind of run out of letters, and to avoid any confusion around _ prefixes, how about just using different variable names here? Such as a and b or whatever.
Contributor
Author
There was a problem hiding this comment.
Using a, b, etc. sounds fine to me; I've done that (after slightly misinterpreting and first renaming _z to a ^^). I broke the pattern intentionally since that assignment is part of the example for Box (I figured each reference/pointer would get one letter), but I agree about avoiding _ prefixes. In any case, I don't have a strong preference.
dianne
force-pushed
the
fix-box-deref-example
branch
2 times, most recently
from
cf23bba to
93bd844
Compare
dianne
force-pushed
the
fix-box-deref-example
branch
from
93bd844 to
95aaeee
Compare
ehuss
approved these changes
Mar 13, 2026
rustbot
removed
the
S-waiting-on-review
JonathanBrouwer
added a commit
to JonathanBrouwer/rust
that referenced
this pull request
Mar 23, 2026
Update books ## rust-embedded/book 1 commits in e88aa4403b4bf2071c8df9509160477e40179099..2463edeb8003c5743918b3739a9f6870b86396f5 2026-03-11 17:49:58 UTC to 2026-03-11 17:49:58 UTC - Update teaching material duration for bare-metal Rust (rust-embedded/book#409) ## rust-lang/reference 7 commits in c49e89cc8c7c2c43ca625a8d5b7ad9a53a9ce978..7446bf9697c95d155eef33c6a9d91fbd29a5e359 2026-03-18 01:46:01 UTC to 2026-03-10 18:10:22 UTC - Update `must_use` to use the attribute template (rust-lang/reference#1892) - Add a rule that enum discriminants may not use generic parameters (rust-lang/reference#2206) - Actually move out of Box in moving-out-of-Box test (rust-lang/reference#2204) - Add special cases and links relating to dereferencing boxes (rust-lang/reference#2075) - Move shebang into its own subchapter (rust-lang/reference#2199) - Fields of enums and unions should be allowed to overlap (rust-lang/reference#2168) - [type layout] Clarify size and alignment of pointers to unsized types (rust-lang/reference#2201)
jhpratt
added a commit
to jhpratt/rust
that referenced
this pull request
Mar 24, 2026
Update books ## rust-embedded/book 1 commits in e88aa4403b4bf2071c8df9509160477e40179099..2463edeb8003c5743918b3739a9f6870b86396f5 2026-03-11 17:49:58 UTC to 2026-03-11 17:49:58 UTC - Update teaching material duration for bare-metal Rust (rust-embedded/book#409) ## rust-lang/reference 7 commits in c49e89cc8c7c2c43ca625a8d5b7ad9a53a9ce978..7446bf9697c95d155eef33c6a9d91fbd29a5e359 2026-03-18 01:46:01 UTC to 2026-03-10 18:10:22 UTC - Update `must_use` to use the attribute template (rust-lang/reference#1892) - Add a rule that enum discriminants may not use generic parameters (rust-lang/reference#2206) - Actually move out of Box in moving-out-of-Box test (rust-lang/reference#2204) - Add special cases and links relating to dereferencing boxes (rust-lang/reference#2075) - Move shebang into its own subchapter (rust-lang/reference#2199) - Fields of enums and unions should be allowed to overlap (rust-lang/reference#2168) - [type layout] Clarify size and alignment of pointers to unsized types (rust-lang/reference#2201)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I looked at #2075 again after it merged and noticed a test I wrote there is wrong; oops!
let _ = $place;doesn't actually perform a move; a place-to-value coercion is needed.